On Wed, Aug 27, 2014 at 08:56:14AM +0100, Lee Jones wrote:
[...]
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 8d5fad2..fae8c5b 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -582,6 +582,17 @@ config MFD_RC5T583
> > Additional drivers must be enabled in order to use the
> > different functionality of the device.
> >
> > +config MFD_RN5T618
> > + bool "Ricoh RN5T5618 PMIC"
>
> Shouldn't this be tristate?
Yes, I suppose the driver would work also as a module, I only have to
uninstall the pm_power_off hook on module removal.
> > +++ b/drivers/mfd/rn5t618.c
> > @@ -0,0 +1,129 @@
>
> [...]
>
> > +static int rn5t618_i2c_probe(struct i2c_client *i2c,
> > + const struct i2c_device_id *id)
> > +{
>
> [...]
>
> > + dev_info(&i2c->dev, "RN5T618 MFD driver loaded");
>
> Can you remove this line? We normally only print things when
> information is gathered from a chip i.e. version information and the
> like.
I will remove it, thanks.
Beniamino
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
