On 17.12.2021 13:57, Felipe Balbi wrote:
> From: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxx>
>
> Add a minimal framebuffer device so we can use the display on the
> Surface Duo device.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxx>
> ---
> .../dts/qcom/sm8150-microsoft-surface-duo.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
> index a73317e1a824..c629ec115fec 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-microsoft-surface-duo.dts
> @@ -25,6 +25,17 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + framebuffer0: framebuffer@9c000000 {
> + compatible = "simple-framebuffer";
> + reg = <0 0x9c000000 0 0x02400000>;
You can remove the leading 0 in the size cell.
> + status = "okay";
This line is unnecessary, as it's enabled by default
> +
> + height = <1800>;
> + width = <1350>;
> + stride = <(1350 * 4)>;
> + format = "a8r8g8b8";
> + };
> +
> vph_pwr: vph-pwr-regulator {
> compatible = "regulator-fixed";
> regulator-name = "vph_pwr";
> @@ -472,6 +483,14 @@ &pon_resin {
> linux,code = <KEY_VOLUMEDOWN>;
> };
>
> +&reserved_memory {
> + splash_region: splash_region@9c000000 {
> + /* We expect the bootloader to fill in the size */
Would it be different than the framebuffer size?
> + reg = <0x0 0x9c000000 0x0 0x0>;
> + no-map;
> + };
> +};
> +
> &tlmm {
> gpio-reserved-ranges = <126 4>;
>
Konrad
