On Tue, 07 Dec 2021 22:08:19 +0100, Jonathan Neuschäfer wrote: > This binding is heavily based on the one for NPCM7xx, because the > hardware is similar. There are some notable differences, however: > > - The addresses of GPIO banks are not physical addresses but simple > indices (0 to 7), because the GPIO registers are not laid out in > convenient blocks. > - Pinmux settings can explicitly specify that the GPIO mode is used. > > Certain pins support blink patterns in hardware. This is currently not > modelled in the DT binding. > > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> > > > --- > v2: > - Move GPIO into subnodes > - Improve use of quotes > - Remove unnecessary minItems/maxItems lines > - Remove "phandle: true" > - Use separate prefixes for pinmux and pincfg nodes > - Add nuvoton,interrupt-map property > - Make it possible to set pinmux to GPIO explicitly > > v1: > - https://lore.kernel.org/lkml/20210602120329.2444672-5-j.neuschaefer@xxxxxxx/ > --- > .../pinctrl/nuvoton,wpcm450-pinctrl.yaml | 190 ++++++++++++++++++ > 1 file changed, 190 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.example.dt.yaml: pinctrl@b8003000: gpio@0:interrupts: [[2, 4, 3, 4, 4, 4]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.example.dt.yaml: pinctrl@b8003000: mux_uid: Additional properties are not allowed ('phandle' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.example.dt.yaml: pinctrl@b8003000: cfg_uid: Additional properties are not allowed ('phandle' was unexpected) From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.example.dt.yaml: pinctrl@b8003000: '#address-cells', '#size-cells' do not match any of the regexes: '^cfg_.*$', '^gpio@.*$', '^mux_.*$', 'pinctrl-[0-9]+' From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/nuvoton,wpcm450-pinctrl.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1564902 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
