On 12/6/21 6:41 PM, Rob Herring wrote:
> With 'unevaluatedProperties' support implemented, the following warnings
> are generated in the nvmem examples:
>
> Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected)
> Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected)
>
> Add the missing 'reg' property definition.
>
> Cc: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> Cc: Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>
> Cc: Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>
> Cc: Rafał Miłecki <rafal@xxxxxxxxxx>
> Cc: Saenz Julienne <nsaenzjulienne@xxxxxxx>
> Cc: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
> Cc: linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 3 +++
> Documentation/devicetree/bindings/nvmem/rmem.yaml | 3 +++
> Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++
> 3 files changed, 9 insertions(+)
Hi Rob,
For the stm32-romem, you can add my:
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@xxxxxxxxxxx>
Thanks,
Fabrice
>
> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> index 58ff6b0bdb1a..8c3f0cd22821 100644
> --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> @@ -24,6 +24,9 @@ properties:
> compatible:
> const: brcm,nvram
>
> + reg:
> + maxItems: 1
> +
> unevaluatedProperties: false
>
> examples:
> diff --git a/Documentation/devicetree/bindings/nvmem/rmem.yaml b/Documentation/devicetree/bindings/nvmem/rmem.yaml
> index 1d85a0a30846..a4a755dcfc43 100644
> --- a/Documentation/devicetree/bindings/nvmem/rmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/rmem.yaml
> @@ -19,6 +19,9 @@ properties:
> - raspberrypi,bootloader-config
> - const: nvmem-rmem
>
> + reg:
> + maxItems: 1
> +
> no-map:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> index a48c8fa56bce..448a2678dc62 100644
> --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml
> @@ -24,6 +24,9 @@ properties:
> - st,stm32f4-otp
> - st,stm32mp15-bsec
>
> + reg:
> + maxItems: 1
> +
> patternProperties:
> "^.*@[0-9a-f]+$":
> type: object
>
