On 03/12/21 12:17PM, Dinh Nguyen wrote: > The QSPI controller on Intel's SoCFPGA platform does not implement the > CQSPI_REG_WR_COMPLETION_CTRL register, thus a write to this register > results in a crash. > > The module/revision ID is written in the MODULE_ID register. For this > variance, bits 23-8 is 0x0010. When I looked at your original patches I was under the impression that this was a SoCFPGA specific thing and did not apply to other implementation of the IP in general. If this is indeed a generic thing and we can detect it via the MODULE_ID register [0], then why not just read that register at probe time and apply this quirk based on the ID? Why then do we need a separate compatible at all? [0] I would like to see it stated explicitly somewhere that version 0x0010 does not support the WR_COMPLETION_CTRL register. -- Regards, Pratyush Yadav Texas Instruments Inc.
