Hi Chris, some nitpicks here, > + > + sfp: sfp { > + compatible = "sff,sfp"; > + i2c-bus = <&cp0_i2c1>; > + mod-def0-gpios = <&expander0 3 GPIO_ACTIVE_LOW>; > + los-gpio = <&expander0 15 GPIO_ACTIVE_HIGH>; > + tx-disable-gpio = <&expander0 2 GPIO_ACTIVE_HIGH>; > + tx-fault-gpio = <&cp0_gpio1 24 GPIO_ACTIVE_HIGH>; maximum-power-milliwatt = <3000>; AFAIK ... > + port@9 { > + reg = <9>; > + label = "p9"; > + phy-mode = "10gbase-r"; > + sfp = <&sfp>; > + managed = "in-band-status"; > + }; > + > + port@10 { port@a (hexadecimal in node name) > + reg = <10>; > + label = "cpu"; > + ethernet = <&cp0_eth0>; Marek