Re: [PATCH] dt-bindings: media: nxp,imx7-mipi-csi2: Drop bad if/then schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Rob,

On Thu, Dec 02, 2021 at 04:26:23PM -0600, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 3:06 PM Laurent Pinchart wrote:
> > On Wed, Dec 01, 2021 at 08:30:21PM -0600, Rob Herring wrote:
> > > The if/then schema for 'data-lanes' doesn't work as 'compatible' is at a
> > > different level than 'data-lanes'. To make it work, the if/then schema
> > > would have to be moved to the top level and then whole hierarchy of
> > > nodes down to 'data-lanes' created. I don't think it is worth the
> > > complexity to do that, so let's just drop it.
> >
> > Fair enough, but then shouldn't there be a comment in the data-lanes
> > property to tell that i.MX7 only supports up to 2 data lanes ?
> 
> I'll add this to data-lanes:
> 
> description: Note that 'fsl,imx7-mipi-csi2' only supports up to 2 data lines.

Looks good to me.

> I assume it is 1 or 2 and not only 2, right?

Correct.

-- 
Regards,

Laurent Pinchart



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux