On Mon, Nov 22, 2021, at 23:58, Janne Grunau wrote:
> Apple M1 has at least 5 i2c controllers. i2c0, i2c1 and i2c3 are used
> on all M1 Mac devices. The 2020 Mac Mini uses i2c2 and the 13-inch
> MacBook Pro uses i2c2 and i2c4.
>
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
> ---
> arch/arm64/boot/dts/apple/t8103-j274.dts | 4 ++
> arch/arm64/boot/dts/apple/t8103-j293.dts | 8 +++
> arch/arm64/boot/dts/apple/t8103.dtsi | 92 ++++++++++++++++++++++++
> 3 files changed, 104 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/apple/t8103-j274.dts
> b/arch/arm64/boot/dts/apple/t8103-j274.dts
> index 9e01ef70039d..2cd429efba5b 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j274.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j274.dts
> @@ -39,3 +39,7 @@ ethernet0: ethernet@0,0 {
> local-mac-address = [00 10 18 00 00 00];
> };
> };
> +
> +&i2c2 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts
> b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index 466035f00b69..49cdf4b560a3 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -31,3 +31,11 @@ &pcie0_dart_2 {
>
> /delete-node/ &port01;
> /delete-node/ &port02;
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/apple/t8103.dtsi
> b/arch/arm64/boot/dts/apple/t8103.dtsi
> index c320c8baeb41..15fec48f943a 100644
> --- a/arch/arm64/boot/dts/apple/t8103.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103.dtsi
> @@ -126,6 +126,73 @@ serial0: serial@235200000 {
> status = "disabled";
> };
>
> + i2c0: i2c@235010000 {
> + compatible = "apple,t8103-i2c", "apple,i2c";
> + reg = <0x2 0x35010000 0x0 0x4000>;
> + clocks = <&clk24>;
> + clock-names = "ref";
No need for clock-names in these nodes. The schema only allows a single clock
anyway.
With that removed and Hector's comments addressed:
Reviewed-by: Sven Peter <sven@xxxxxxxxxxxxx>
