On Mon, Aug 18, 2014 at 05:17:44PM +0100, Mark Rutland wrote:
> On Sun, Aug 17, 2014 at 11:49:52AM +0100, Carlo Caione wrote:
<cut>
> > + soc@c8100000 {
>
> What's the unit-address for? This node doesn't have a reg or compatible.
I used it to indicate the starting address of the memory mapped region.
> > + compatible = "simple-bus";
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges;
> > +
> > + uart_AO: serial@c81004c0 {
> > + compatible = "amlogic,meson-uart";
> > + reg = <0xc81004c0 0x14>;
> > + interrupts = <0 90 1>;
> > + clocks = <&clk81>;
> > + status = "disabled";
> > + };
> > +
> > + uart_A: serial@c81084c0 {
> > + compatible = "amlogic,meson-uart";
> > + reg = <0xc81084c0 0x14>;
> > + interrupts = <0 90 1>;
> > + clocks = <&clk81>;
> > + status = "disabled";
> > + };
> > +
> > + uart_B: serial@c81084dc {
> > + compatible = "amlogic,meson-uart";
> > + reg = <0xc81084dc 0x14>;
> > + interrupts = <0 90 1>;
> > + clocks = <&clk81>;
> > + status = "disabled";
> > + };
> > +
> > + uart_C: serial@c8108700 {
> > + compatible = "amlogic,meson-uart";
> > + reg = <0xc8108700 0x14>;
> > + interrupts = <0 90 1>;
> > + clocks = <&clk81>;
> > + status = "disabled";
>
> I guess these are disabled because they aren't always wired up?
Yes
<cut>
> > + clocks {
> > + #address-cells = <1>;
> > +
> > + clk81: clk@0 {
> > + #clock-cells = <0>;
> > + compatible = "fixed-clock";
> > + clock-frequency = <200000000>;
> > + };
> > + };
>
> There is really no need to put clocks in a container.
>
> Just put them under the root, and drop the unit-address.
I'll do, thanks.
--
Carlo Caione
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
