On Thu, 11 Nov 2021 11:12:58 +0100 Andrea Merello <andrea.merello@xxxxxxxxx> wrote: > Just an inline comment; OK for the rest. > > > +#include <linux/i2c.h> > > > > Why? I'm not seeing an i2c specific calls in here. > > Because of the definition of struct i2c_client, that is being accessed > in lines like this > dev_err(&client->dev, "Unable to init register map"); doh. I was clearly being a bit unobservant that day.
