Hi Biju, On Thu, Nov 4, 2021 at 5:09 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > Describe the WDT hardware in the RZ/G2L series. > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/renesas,wdt.yaml > @@ -75,17 +79,49 @@ required: > - reg > - clocks > > -if: > - not: > - properties: > - compatible: > - contains: > - enum: > - - renesas,rza-wdt > -then: > - required: > - - power-domains > - - resets > +allOf: > + - $ref: "watchdog.yaml#" > + > + - if: > + not: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rza-wdt > + then: > + required: > + - power-domains > + - resets > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - renesas,rzg2l-wdt > + then: > + properties: > + interrupts: > + maxItems: 2 > + interrupt-names: > + items: > + - const: wdt > + - const: perrout > + clocks: > + items: > + - description: Main clock > + - description: Register access clock > + clock-names: > + items: > + - const: oscclk > + - const: pclk Usually we put the internal module clock first. Please add (at least the first one): required: - clock-names - interrupt-names > + else: > + properties: > + interrupts: > + maxItems: 1 > + clocks: > + maxItems: 1 > > additionalProperties: false Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds