On 31/10/2021 13:22, Sam Protsenko wrote: > Now that PMU enablement code was extended for new Exynos SoCs, it > doesn't look very cohesive and consistent anymore. Do a bit of renaming, > grouping and style changes, to make it look good again. > > No functional change, just a refactoring commit. > > Signed-off-by: Sam Protsenko <semen.protsenko@xxxxxxxxxx> > --- > Changes in v2: > - (none): it's a new patch > > drivers/watchdog/s3c2410_wdt.c | 48 ++++++++++++++++------------------ > 1 file changed, 23 insertions(+), 25 deletions(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index ec341c876225..fdb1a1e9bd04 100644 > --- a/drivers/watchdog/s3c2410_wdt.c > +++ b/drivers/watchdog/s3c2410_wdt.c > @@ -56,17 +56,16 @@ > #define EXYNOS5_RST_STAT_REG_OFFSET 0x0404 > #define EXYNOS5_WDT_DISABLE_REG_OFFSET 0x0408 > #define EXYNOS5_WDT_MASK_RESET_REG_OFFSET 0x040c Please document the meaning of each quirk with 1-2 sentences. Could be in this commit (e.g. "Watchdog reset requests should be unmasked in PMU", "Watchdog interrupt needs acking"). In general looks good: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> Best regards, Krzysztof
