The 10/21/2021 23:19, Vinod Koul wrote: > > On 21-10-21, 11:10, Horatiu Vultur wrote: > > The 10/21/2021 11:40, Vinod Koul wrote: > > > > > > On 20-10-21, 17:49, Alexandre Belloni wrote: > > > > On 20/10/2021 21:05:49+0530, Vinod Koul wrote: > > > > > > > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > > > > > > > > > > > > > Any reason why this is dual licensed, why not GPL only? > > > > > > > > > > > > No reason, I think I copy this from a different file. > > > > > > > > > > Please have a chat with your lawyers on the correct license this should > > > > > have! > > > > Dual GPL and MIT was Microsemi's policy, I'm not sure it carried over to > > > > Microchip. > > > > > > That is why they need to talk to someone and decide what license > > > applies :) > > > > I have changed it to be the same as the one on sparx5 because also > > sparx5 is a Microchip product. On sparx5 we used: > > 'SPDX-License-Identifier: GPL-2.0-or-later' > > Has the code been copied/derived from somewhere/auto generated from > scripts/tools or entirely written by you? Sorry for late reply, but I was out of office without access to the emails. The register file 'lan966x_serdes_regs.h' was autogenerated from some internal scripts. Which takes the info from here [1] and generates these header files. The reason why we generate them is that is more error proof that writting them manually. We are doing the same for sparx5 registers[2] The other file 'lan966x_serdes.c' was entirely written by me. [1] https://github.com/microchip-ung/lan9668_reginfo [2] https://elixir.bootlin.com/linux/latest/source/drivers/phy/microchip/sparx5_serdes_regs.h > > -- > ~Vinod -- /Horatiu
