On Tue, Oct 26, 2021 at 05:27:32PM -0400, Jim Quinlan wrote: > I don't think it matters but our PCIe controllers only have a single > root port. Just to kibitz, and I don't know anything about the DT binding under discussion here, but I would prefer if DTs and drivers did not have the "single root port" assumption baked deeply in them. I expect some controllers to support multiple root ports, and it would be really nice if the DTs and drivers all had similar structures with the single-root-port controllers just being the N=1 case. For example, some drivers put their per-root port stuff in *_add_pcie_port() functions, which I think is a nice way to do it because it leaves the door open for calling *_add_pcie_port() in a loop. Ironically, the only driver I see that looks like it currently supports multiple root ports is pci-mvebu.c, and it doesn't have an _add_pcie_port() function. Having this sort of consistent structure and naming across drivers is a huge help for ongoing maintenance. Bjorn
