Hi dee Ho Marek, Thanks! I like the idea and appreciate the improvement. On 10/20/21 11:49, Marek Vasut wrote: > Add the possibility to configure PMIC 32kHz output clock as CRITICAL, > so that they are never gated off. This is useful in case those clock > supply some vital clock net, which requires the clock to always run. > > The iMX8M RTC XTAL input is one such example, if the clock are ever > gated off, the system locks up completely. The clock must be present > and enabled even if the RTC is unused. > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > Cc: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx> > Cc: Michael Turquette <mturquette@xxxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Stephen Boyd <sboyd@xxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Cc: linux-power@xxxxxxxxxxxxxxxxx > To: linux-clk@xxxxxxxxxxxxxxx > --- > Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml > index 5d531051a153..2497ade2bbd0 100644 > --- a/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml > +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71847-pmic.yaml > @@ -41,6 +41,11 @@ properties: > clock-output-names: > maxItems: 1 > > + rohm,clock-output-is-critical: I wonder if this really is something specific to ROHM ICs? Do you think this would warrant a generic, non vendor specific property? I am Ok with the ROHM specific property too but it just seems to me this might not be unique to ROHM IC(s). By the way, the very same clk driver where you implemented the property reading (patch 2/2) is used by few other ROHM PMICs. At least by BD71837, BD71828, BD71815, BD9576 and BD9573. So the code change here adds support for this property to all of those PMICs. I wonder if the property should be mentioned in all of the binding docs... That could be another argument for making this a generic property and describing it in clk yaml ;) Well, just my 10 Cents - I am ok with this change as you presented it here if you don't think this should be generic one. > + description: > + Never gate off C32K_OUT clock. > + type: boolean > + > # The BD71847 abd BD71850 support two different HW states as reset target > # states. States are called as SNVS and READY. At READY state all the PMIC > # power outputs go down and OTP is reload. At the SNVS state all other logic > Best Regards Matti Vaittinen
