On 12.10.2021 10:13, Sam Protsenko wrote:
On Mon, 11 Oct 2021 at 13:42, Sylwester Nawrocki<s.nawrocki@xxxxxxxxxxx> wrote:
On 11.10.2021 12:13, Sam Protsenko wrote:
On Sat, 9 Oct 2021 at 23:41, Sylwester Nawrocki<snawrocki@xxxxxxxxxx> wrote:
On 08.10.2021 17:43, Sam Protsenko wrote:
Provide dt-schema documentation for Exynos850 SoC clock controller.
Signed-off-by: Sam Protsenko<semen.protsenko@xxxxxxxxxx>
Reviewed-by: Krzysztof Kozlowski<krzysztof.kozlowski@xxxxxxxxxxxxx>
Acked-by: Chanwoo Choi<cw00.choi@xxxxxxxxxxx>
[...]
+++ b/Documentation/devicetree/bindings/clock/samsung,exynos850-clock.yaml
@@ -0,0 +1,185 @@
[...]
+
+title: Samsung Exynos850 SoC clock controller
+
+maintainers:
+ - Sam Protsenko<semen.protsenko@xxxxxxxxxx>
+ - Chanwoo Choi<cw00.choi@xxxxxxxxxxx>
+ - Krzysztof Kozlowski<krzysztof.kozlowski@xxxxxxxxxxxxx>
+ - Sylwester Nawrocki<s.nawrocki@xxxxxxxxxxx>
+ - Tomasz Figa<tomasz.figa@xxxxxxxxx>
+
+description: |
+ Exynos850 clock controller is comprised of several CMU units, generating
+ clocks for different domains. Those CMU units are modeled as separate device
+ tree nodes, and might depend on each other. Root clocks in that clock tree are
+ two external clocks:: OSCCLK (26 MHz) and RTCCLK (32768 Hz). Those external
+ clocks must be defined as fixed-rate clocks in dts.
+
+ CMU_TOP is a top-level CMU, where all base clocks are prepared using PLLs and
+ dividers; all other leaf clocks (other CMUs) are usually derived from CMU_TOP.
+
+ Each clock is assigned an identifier and client nodes can use this identifier
+ to specify the clock which they consume. All clocks that available for usage
s/All clocks that available/All clocks available ?
No need to resend, I can amend it when applying.
Yeah, not a native speaker, I tend to do such mistakes sometimes:)
Please fix when applying.
Btw, I can see that you already applied 3 out of 5 patches from this
patch series here: [1]. Can you please also apply the rest, or is
there any outstanding comments that I missed?
The patches look good to me, I just wanted to allow some for Rob to have
a look and provide an Ack.
Can you please review this one?
The binding is rather straightforward so I applied the patch now, thank you.
