On Tue, Oct 12, 2021 at 10:08:49PM -0500, Rob Herring wrote: > On Wed, 13 Oct 2021 03:16:21 +0200, Ansuel Smith wrote: > > From: Matthew Hagan <mnhagan88@xxxxxxxxx> > > > > Convert the qca8k bindings to YAML format. > > > > Signed-off-by: Matthew Hagan <mnhagan88@xxxxxxxxx> > > Co-developed-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > Signed-off-by: Ansuel Smith <ansuelsmth@xxxxxxxxx> > > --- > > .../devicetree/bindings/net/dsa/qca8k.txt | 245 ------------ > > .../devicetree/bindings/net/dsa/qca8k.yaml | 362 ++++++++++++++++++ > > 2 files changed, 362 insertions(+), 245 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/net/dsa/qca8k.txt > > create mode 100644 Documentation/devicetree/bindings/net/dsa/qca8k.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/net/dsa/qca8k.yaml:362:7: [error] no new line character at the end of file (new-line-at-end-of-file) > Stupid me will fix that... > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/qcom,ipq8064-mdio.example.dt.yaml: switch@10: 'oneOf' conditional failed, one must be fixed: > 'ports' is a required property > 'ethernet-ports' is a required property > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/net/dsa/qca8k.yaml > About this i fixed with the next patch. Should I include that in this patch? Or i can ignore this error? > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1540096 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > -- Ansuel
