Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: rzg2l-smarc: Enable microSD
> on SMARC platform
>
> Hi Biju,
>
> On Thu, Oct 7, 2021 at 5:55 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > This patch enables microSD card slot connected to SDHI1 on RZ/G2L
> > SMARC platform.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> > @@ -70,6 +70,16 @@
> > regulator-min-microvolt = <5000000>;
> > regulator-max-microvolt = <5000000>;
> > };
> > +
> > + vccq_sdhi1: regulator-vccq-sdhi1 {
> > + compatible = "regulator-gpio";
> > + regulator-name = "SDHI1 VccQ";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <3300000>;
> > + gpios = <&pinctrl RZG2L_GPIO(39, 1) GPIO_ACTIVE_HIGH>;
>
> Is this correct? Schematics say GPIO high is 3.3V.
>
> > + gpios-states = <1>;
> > + states = <3300000 1 1800000 0>;
OK. Will fix this like previous patch.
> > + };
> > };
> >
> > &audio_clk1{
> > @@ -199,6 +209,45 @@
> > <RZG2L_PORT_PINMUX(38, 1, 1)>; /* RxD */
> > };
> >
> > + sd1_pwr_en {
>
> sd1-pwr-en-hog (like in the example in
> Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml ;-)
>
OK.
Will fix this in next version.
Regards,
Biju
>
> > + gpio-hog;
> > + gpios = <RZG2L_GPIO(39, 2) GPIO_ACTIVE_HIGH>;
> > + output-high;
> > + line-name = "sd1_pwr_en";
> > + };
>
> The rest looks good to me.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
