On 07/10/21 02:54AM, Laurent Pinchart wrote: > Hi Pratyush, > > Thank you for the patch. > > On Wed, Sep 15, 2021 at 05:32:40PM +0530, Pratyush Yadav wrote: [...] > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: CSI-2 input > > + > > + properties: > > + endpoint: > > + $ref: video-interfaces.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + clock-lanes: > > + maxItems: 1 > > + > > + data-lanes: > > + minItems: 1 > > + maxItems: 4 > > + items: > > + maximum: 4 > > + > > + required: > > + - clock-lanes > > + - data-lanes > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Stream 0 output > > + > > + port@2: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Stream 1 output > > + > > + port@3: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Stream 2 output > > + > > + port@4: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: Stream 3 output > > + > > + required: > > + - port@0 > > + > > + > > +dependencies: > > + phys: [ 'phy-names' ] > > + phy-names: [ 'phys' ] > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - clock-names > > Shouldn't "ports" be required too ? Yes, it should be. Will fix. Thanks. > > With those comments addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > -- Regards, Pratyush Yadav Texas Instruments Inc.