On Fri, Aug 08, 2014 at 03:07:33PM +0100, Nick Dyer wrote: > On 07/08/14 08:44, Javier Martinez Canillas wrote: > > The Atmel maXTouch driver assumed that the IRQ type flags will > > always be passed using platform data but this is not true when > > booting using Device Trees. In these setups the interrupt type > > was ignored by the driver when requesting an IRQ. > > > > This means that it will fail if a machine specified other type > > than IRQ_TYPE_NONE. The right approach is to get the IRQ flags > > that was parsed by OF from the "interrupt" Device Tree propery. > > > > Signed-off-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx> > > I'm happy for this to go in if Dmitry will accept it. It does seem to be a > quirk of some platforms that it is necessary, but it's only one line. I'd rather not as it masks the deeper platform issue. There might be other drovers also expecting platform/OF code set up interrupt triggers and working/not working by chance. Can we figure out why the platform in question needs this change? Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
