On Fri 01 Oct 00:08 PDT 2021, Vladimir Zapolskiy wrote:
> On 9/30/21 9:21 PM, Bjorn Andersson wrote:
[..]
> > diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
[..]
> > @@ -895,12 +892,14 @@ static int qcom_smem_map_memory(struct qcom_smem *smem, struct device *dev,
> > static int qcom_smem_probe(struct platform_device *pdev)
> > {
> > struct smem_header *header;
> > + struct reserved_mem *rmem;
> > struct qcom_smem *smem;
> > size_t array_size;
> > int num_regions;
> > int hwlock_id;
> > u32 version;
> > int ret;
> > + int i;
>
> Just a nitpicking, the index can be unsigned.
>
It's compared against the "num_regions", which is also signed. So I
think it should be signed.
[..]
> > + for (i = 0; i < num_regions; i++) {
Thanks for the review!
Regards,
Bjorn
