Hi Arnd, > > > (priv->rst); > > > + if (ret) > > > + goto err_assert_power; > > > + } > > > > I wouldn't make these optional, just call the functions > > unconditionally and fail the probe function if they are > > not available. Also I've also done as you suggest and made these non optional in V4. regards, Peter. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html