On Wednesday 06 August 2014, Peter Griffin wrote:
> +int st_usb_platform_power_on(struct st_platform_priv *priv)
> +{
> + int clk, ret;
> +
> + if (priv->pwr) {
> + ret = reset_control_deassert(priv->pwr);
> + if (ret)
> + return ret;
> + }
> +
> + if (priv->rst) {
> + ret =
> (priv->rst);
> + if (ret)
> + goto err_assert_power;
> + }
I wouldn't make these optional, just call the functions
unconditionally and fail the probe function if they are
not available.
I'm not sure if it's worth keeping these functions in a
common file. You are adding complexity this way and I don't
think you are even saving a significant number of code lines
compared to just having two copies of them.
> +EXPORT_SYMBOL(st_usb_platform_power_on);
If you want to keep them, it would be best to make
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
