> -----Original Message----- > From: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Sent: Monday, September 27, 2021 4:27 PM > To: Richard Zhu <hongxing.zhu@xxxxxxx>; kishon@xxxxxx; vkoul@xxxxxxxxxx; > robh@xxxxxxxxxx; galak@xxxxxxxxxxxxxxxxxxx; shawnguo@xxxxxxxxxx > Cc: linux-phy@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > kernel@xxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH v2 1/4] dt-bindings: phy: phy-imx8-pcie: Add binding for > the pad modes of imx8 pcie phy > > Am Sonntag, dem 26.09.2021 um 15:39 +0800 schrieb Richard Zhu: > > Add binding for reference clock PAD modes of the i.MX8 PCIe PHY. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> > > --- > > include/dt-bindings/phy/phy-imx8-pcie.h | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > create mode 100644 include/dt-bindings/phy/phy-imx8-pcie.h > > > > diff --git a/include/dt-bindings/phy/phy-imx8-pcie.h > > b/include/dt-bindings/phy/phy-imx8-pcie.h > > new file mode 100644 > > index 000000000000..59ed322f8d6c > > --- /dev/null > > +++ b/include/dt-bindings/phy/phy-imx8-pcie.h > > @@ -0,0 +1,14 @@ > > +/* SPDX-License-Identifier: GPL-2.0+ */ > > This should be (GPL-2.0+ OR MIT) to be compatible with the license of the > DTSI file it is included in. [Richard Zhu] Thanks for your comments. Okay, would be changed as this one later. > > > +/* > > + * This header provides constants for i.MX8 PCIe. > > + */ > > + > > +#ifndef _DT_BINDINGS_IMX8_PCIE_H > > +#define _DT_BINDINGS_IMX8_PCIE_H > > + > > +/* Reference clock PAD mode */ > > +#define IMX8_PCIE_REFCLK_PAD_NO_USED 0 > > I think _UNUSED would be the more idiomatic way to call this. > [Richard Zhu] Okay, got that. Thanks. Best Regards Richard Zhu > > +#define IMX8_PCIE_REFCLK_PAD_INPUT 1 > > +#define IMX8_PCIE_REFCLK_PAD_OUTPUT 2 > > + > > +#endif /* _DT_BINDINGS_IMX8_PCIE_H */ >
