Hi, no, I don't have this patch. I will give it a try. Thanks. Greetings Sebastian Priebe ========================================== CADCON Ingenieurgesellschaft mbH & Co. KG Geschaeftsfuehrer: Robert Bauer, Andreas Gundel Sitz der Gesellschaft: D-86368 Gersthofen Registergericht: Amtsgericht Augsburg HRA 14521 ========================================== -----Ursprüngliche Nachricht----- Von: Liu Ying [mailto:liu.y.victor@xxxxxxxxx] Gesendet: Mittwoch, 6. August 2014 16:02 An: Priebe, Sebastian Cc: Sascha Hauer; devicetree@xxxxxxxxxxxxxxx Betreff: Re: driver using another driver Hi Sebastian, 2014-08-01 17:08 GMT+08:00 Priebe, Sebastian <Sebastian.Priebe@xxxxxxxxx>: Hello Sascha, I don't register a platform driver manually anymore. As I wrote before, I turned the CPLD driver in a platform driver and created an entry in the device tree. But I get an error in the probe: res = platform_get_resource(pdev, IORESOURCE_MEM, 0) returns NULL. Does your kernel contain this patch[1]? This patch is needed to populate the devices on the simple bus of i.MX WEIM. And, it has been queued in linux-next. [1] https://lkml.org/lkml/2014/7/4/129 Regards, Liu Ying Greetings Sebastian Priebe Telefon: +49 (0)621 685996-26 <tel:%2B49%20%280%29621%20685996-26> ========================================== CADCON Ingenieurgesellschaft mbH & Co. KG Geschaeftsfuehrer: Robert Bauer, Andreas Gundel Sitz der Gesellschaft: D-86368 Gersthofen Registergericht: Amtsgericht Augsburg HRA 14521 ========================================== -----Ursprüngliche Nachricht----- Von: Sascha Hauer [mailto:s.hauer@xxxxxxxxxxxxxx] Gesendet: Freitag, 1. August 2014 10:52 An: Priebe, Sebastian Cc: devicetree@xxxxxxxxxxxxxxx Betreff: Re: driver using another driver On Fri, Aug 01, 2014 at 07:15:41AM +0000, Priebe, Sebastian wrote: > Hello Sascha, > > thanks for your answer. > We are using an imx35 cpu and our CPLD is in fact connected via weim (CS1). > Though I created the following device node in our dts: > &weim { > pinctrl-names = "default"; > status = "okay"; > > pld@1,0 { > compatible = "roche,hbm-pld"; > reg = <1 0x00000000 0x0001000>; > fsl,weim-cs-timing = <0x0 0x0 0x0>; /* don't know what to put here */ > }; > }; > > And I turned the CPLD driver into a platform driver. But I don't get the resource in probe: > res = platform_get_resource(pdev, IORESOURCE_MEM, 0) returns NULL. > > In our platform code we had: > static struct resource hbm_pld_resource_data = { > .start = 0xA8000000, > .end = 0xA8000000 + 0x1000 - 1, > .flags = IORESOURCE_MEM, > }; Why do you manually register a platform_device? You should add the CPLD device to the device tree instead. > > And for the setting of CS1: > __raw_writel((0x22 << 8), MX35_IO_ADDRESS(MX3x_WEIM_BASE_ADDR) + > 0x10); __raw_writel(((0x0a << 28) | (0x06 << 12) | (0x03 << 8) | (0x04 > << 4) | (0x01 << 0)), MX35_IO_ADDRESS(MX3x_WEIM_BASE_ADDR) + 0x14); > > Where do I put this in the device tree? In the fsl,weim-cs-timing property. See Documentation/devicetree/bindings/bus/imx-weim.txt Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 <tel:%2B49-5121-206917-0> | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 <tel:%2B49-5121-206917-5555> | -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- Best Regards, Liu Ying ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
