On 23/09/2021 15:21, Michael Ellerman wrote: > Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> writes: >> g5_phy_disable_cpu1() is used outside of platforms/powermac/feature.c, >> so it should have a declaration to fix W=1 warning: >> >> arch/powerpc/platforms/powermac/feature.c:1533:6: >> error: no previous prototype for ‘g5_phy_disable_cpu1’ [-Werror=missing-prototypes] >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx> >> >> --- >> >> Changes since v1: >> 1. Drop declaration in powermac/smp.c > > Sorry I missed v1, so I'm going to ask for more changes :} > >> arch/powerpc/include/asm/pmac_feature.h | 4 ++++ > > Putting it here exposes it to the whole kernel, but it's only needed > inside arch/powerpc/platforms/powermac. > > The right place for the prototype is arch/powerpc/platforms/powermac/pmac.h, > which is for platform internal prototypes. I'll fix it up. > >> arch/powerpc/platforms/powermac/smp.c | 2 -- >> 2 files changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/pmac_feature.h b/arch/powerpc/include/asm/pmac_feature.h >> index e08e829261b6..7703e5bf1203 100644 >> --- a/arch/powerpc/include/asm/pmac_feature.h >> +++ b/arch/powerpc/include/asm/pmac_feature.h >> @@ -143,6 +143,10 @@ >> */ >> struct device_node; >> >> +#ifdef CONFIG_PPC64 >> +void g5_phy_disable_cpu1(void); >> +#endif /* CONFIG_PPC64 */ > > The ifdef around the prototype doesn't gain much, and is extra visual > noise, so I'd rather without it. Sure. Best regards, Krzysztof
