On 2021-09-21 01:23, Stephen Boyd wrote:
Quoting Prasad Malisetty (2021-09-17 10:15:47)
On the SC7280, the clock source for gcc_pcie_1_pipe_clk_src
must be the TCXO while gdsc is enabled. After PHY init successful
clock source should switch to pipe clock for gcc_pcie_1_pipe_clk_src.
Signed-off-by: Prasad Malisetty <pmaliset@xxxxxxxxxxxxxx>
---
One nit below
Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
@@ -1488,7 +1553,9 @@ static int qcom_pcie_probe(struct
platform_device *pdev)
pcie->pci = pci;
- pcie->ops = of_device_get_match_data(dev);
+ pcie_cfg = of_device_get_match_data(dev);
+ pcie->ops = pcie_cfg->ops;
Maybe worth failing probe with if (!pcie->ops) just to be a little
nicer here.
Thanks Stephen, I will add the check in new patch series if any.
+ pcie->pipe_clk_need_muxing = pcie_cfg->pipe_clk_need_muxing;
pcie->reset = devm_gpiod_get_optional(dev, "perst",
GPIOD_OUT_HIGH);
if (IS_ERR(pcie->reset)) {
