Hi Geert, On Wed, Sep 22, 2021 at 08:43:57AM +0200, Geert Uytterhoeven wrote: > On Wed, Sep 22, 2021 at 3:27 AM Laurent Pinchart wrote: > > On Tue, Sep 21, 2021 at 05:53:52PM +0200, Geert Uytterhoeven wrote: > > > On Wed, Jul 28, 2021 at 6:26 PM Laurent Pinchart wrote: > > > > The R-Car MIPI DSI/CSI-2 TX is embedded in the Renesas R-Car V3U SoC. It > > > > can operate in either DSI or CSI-2 mode, with up to four data lanes. > > > > > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > > Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > > > > > > Thanks for your patch! > > > > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dsi-csi2-tx.yaml > > > > @@ -0,0 +1,118 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/display/bridge/renesas,dsi-csi2-tx.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Renesas R-Car MIPI DSI/CSI-2 Encoder > > > > + > > > > +maintainers: > > > > + - Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > > + > > > > +description: | > > > > + This binding describes the MIPI DSI/CSI-2 encoder embedded in the Renesas > > > > + R-Car V3U SoC. The encoder can operate in either DSI or CSI-2 mode, with up > > > > + to four data lanes. > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - renesas,r8a779a0-dsi-csi2-tx # for V3U > > > > + > > > > + reg: > > > > + maxItems: 1 > > > > + > > > > + clocks: > > > > + items: > > > > + - description: Functional clock > > > > + - description: DSI (and CSI-2) functional clock > > > > + - description: PLL reference clock > > > > + > > > > + clock-names: > > > > + items: > > > > + - const: fck > > > > + - const: dsi > > > > + - const: pll > > > > > > No interrupts? > > > The hardware manual says there are 9 interrupts. > > > > Who comes up with such insanely high numbers of interrupts ? :-) > > > > What the hardware manual doesn't document is how interrupts are mapped. > > There's indeed 9 of them, and there are 9 interrupt sources, but that's > > all we know. I can easily add a > > > > interrupts: > > maxItems: 9 > > > > but I can add interrupt names without additional information. It may be > > possible to deduce some of the interrupt mappings from experiments, but > > not all of them. What do you think would be a good way forward ? Leave > > the interrupts out for now as we don't have the information ? Only list > > the interrupts but not their names ? Something else ? > > I think what we did in the past is not list the interrupts at all. > They can be added once we receive more documentation. Sounds good to me, as that's what this patch does already ;-) A R-b or A-b tag is welcome. -- Regards, Laurent Pinchart
