On Tue 14 Sep 02:45 CDT 2021, Shawn Guo wrote: > Add device tree bindings for QCM2290 pinctrl. > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > --- > .../pinctrl/qcom,qcm2290-pinctrl.yaml | 186 ++++++++++++++++++ > 1 file changed, 186 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > [..] > +'$defs': > + qcom-qcm2290-tlmm-state: > + type: object > + description: > + Pinctrl node's client devices use subnodes for desired pin configuration. > + Client device subnodes use below standard properties. > + $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + > + properties: > + pins: > + description: > + List of gpio pins affected by the properties specified in this > + subnode. > + items: > + oneOf: > + - pattern: "^gpio([0-9]|[1-9][0-9]|10[0-9]|11[0-2])$" ^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-6])$ To make it cover the entire gpio space. The rest looks good! Regards, Bjorn