On 9/15/21 15:14, Geert Uytterhoeven wrote:
> Convert the ROHM BD9571MWV/BD9574MWF Power Management Integrated Circuit
> (PMIC) Device Tree binding documentation to json-schema.
>
> Make the "regulators" subnode optional, as not all users describe the
> regulators.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> I have listed Marek as the maintainer, as he wrote the original
> bindings. Marek: Please scream if this is inappropriate ;-)
>
> v2:
> - Add Reviewed-by.
> ---
> .../devicetree/bindings/mfd/bd9571mwv.txt | 69 ----------
> .../bindings/mfd/rohm,bd9571mwv.yaml | 127 ++++++++++++++++++
> 2 files changed, 127 insertions(+), 69 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/bd9571mwv.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd9571mwv.yaml
> + regulators {
> + dvfs: dvfs {
> + regulator-name = "dvfs";
> + regulator-min-microvolt = <750000>;
> + regulator-max-microvolt = <1030000>;
> + regulator-boot-on;
> + regulator-always-on;
Out of the curiosity (and in order to learn) - what is the exact idea of
the 'regulator-boot-on' and when it should be used? I _think_ the
'regulator-boot-on' is in many cases used to make the regulator
framework to enable the regulator at start-up. What I _think_ the
'regulator-boot-on' is intended for is to advertise the regulator
boot-up state for regulators which do not provide a way to get the
state. I am unsure if there is any property which is intended to be used
for enabling the regulator at start-up. DISCLAIMER: Source of these
thoughts is unknown. I may be wrong here. If someone knows this for sure
I'd be grateful for any education :) If I am not mistaken the dvfs
regulator does provide a way of reading the enable state after boot.
Finally, I have seen this quite many times before but I am unsure I
understand it - why setting both the 'regulator-boot-on' and
'regulator-always-on'? Wouldn't the 'regulator-always-on' suffice?
> + };
> + };
> + };
> + };
>
Anyways - as I mentioned, I am not 100% sure of pretty much anything :)
Hence my questions are just questions - and the binding looks good to me.
FWIW:
acked-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
--Matti
