Haojian Zhuang <haojian.zhuang@xxxxxxxxx> writes: > On Thu, Jul 31, 2014 at 4:50 AM, Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: >> +void __init clkdev_pxa_register(int ckid, const char *con_id, >> + const char *dev_id, struct clk *clk) >> +{ >> + if (!IS_ERR(clk) && (ckid != CLK_NONE)) > > Will you specify CLK_NONE in clock driver? I haven't found a use yet (ie. pxa27x has no use for it, while for pxa3xx and pxa25x I don't know yet). I had put that here for a "CKEN" type clock which would be declared, but hidden from device-tree. That's the meaning of "CLK_NONE", hidden from DT. I can remove it if you think that there is no pxaXXX which needs this functionality. > It seems that CLK_NONE isn't used in pxa27x clock driver. And pxa_clocks[0] is > not used. Is it redundant? Yes it is. pxa_clocks[0] is never filled by any clock. Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html