On 2 August 2014 00:13, Mark Brown <broonie@xxxxxxxxxx> wrote:
> On Fri, Aug 01, 2014 at 06:02:45PM +0530, Jassi Brar wrote:
>
>> +Optional property:
>> +- mbox-names: List of identifier strings for each mailbox channel
>> + required by the client. The use of this property
>> + is discouraged in favor of using index in list of
>> + 'mboxes' while requesting a mailbox.
>
> Can I suggest that if we do want to avoid strings for some reason (it's
> not obvious to me why)
>
The string and index are both to be taken from DT node of client.
pwr_cntrl: power {
...
mbox-names = "pwr-ctrl", "rpc";
mboxes = <&mailbox 0
&mailbox 1>;
};
The xlate() will map string onto index. So rather than the client
driver specify, say, "rpc" while requesting mailbox channel, it can
directly specify index 1.
> then we include a recommendation to provide
> defines in a header file in order to improve legibility. That's pretty
> minor, though.
>
Sorry I don't understand.
> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
>
Thanks a lot!
-Jassi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
