Hi, On Thu, Sep 2, 2021 at 3:10 PM Andrzej Hajda <a.hajda@xxxxxxxxxxx> wrote: > > Removed most CC: SMTP server protested. Yeah, it was because of the dang defconfig patches. My general policy is to send the cover letter to everyone even if not everyone gets CCed on all patches, but it ended up as a lot... Speaking of which, I'd definitely be interested in your take on the defconfig topic: https://lore.kernel.org/r/CAD=FV=WPXAUyuAHb1jKx9F_aw+JGX4MWB3or=Eq5rXoKY=OQMw@xxxxxxxxxxxxxx Do you agree with Olof that I should set the "default" for the new config to be the same as the old config? It doesn't make sense going forward but it helps for anyone with old configs... > On 01.09.2021 22:19, Douglas Anderson wrote: > > The goal of this patch series is to move away from hardcoding exact > > eDP panels in device tree files. As discussed in the various patches > > in this series (I'm not repeating everything here), most eDP panels > > are 99% probable and we can get that last 1% by allowing two "power > > up" delays to be specified in the device tree file and then using the > > panel ID (found in the EDID) to look up additional power sequencing > > delays for the panel. > > > > This patch series is the logical contiunation of a previous patch > > series where I proposed solving this problem by adding a > > board-specific compatible string [1]. In the discussion that followed > > it sounded like people were open to something like the solution > > proposed in this new series. > > > > In version 2 I got rid of the idea that we could have a "fallback" > > compatible string that we'd use if we didn't recognize the ID in the > > EDID. This simplifies the bindings a lot and the implementation > > somewhat. As a result of not having a "fallback", though, I'm not > > confident in transitioning any existing boards over to this since > > we'll have to fallback to very conservative timings if we don't > > recognize the ID from the EDID and I can't guarantee that I've seen > > every panel that might have shipped on an existing product. The plan > > is to use "edp-panel" only on new boards or new revisions of old > > boards where we can guarantee that every EDID that ships out of the > > factory has an ID in the table. > > > > Version 3 of this series now splits out all eDP panels to their own > > driver and adds the generic eDP panel support to this new driver. I > > believe this is what Sam was looking for [2]. > > > > [1] https://lore.kernel.org/r/YFKQaXOmOwYyeqvM@xxxxxxxxxx/ > > [2] https://lore.kernel.org/r/YRTsFNTn%2FT8fLxyB@xxxxxxxxxxxx/ > > > I like the idea - if something can be configured dynamically lets do it. > But I have few questions: > 1. Have you read different real panels id's? In many cases (MIPI DSI, > LVDS with EDID) manufacturers often forgot to set proper id fields. I do > not know how EDID's ids are reliable in case of edp panels. I have read several and (so far) they have been quite reliable but I will admit that I haven't done an exhaustive sample. I guess my answer to whether we can trust it is: a) Presumably you'd only use this new "edp-panel" compatible on systems whose panel IDs are known to be reliable. Old systems can keep determining the panel by compatible string. The two schemes can co-exist. b) As we start using this new scheme then there will be more validation of panel ID strings and, presumably, they will become more reliable. It is still true that ID conflicts could exist. A vendor could ship two different panels with the same ID and maybe nobody would notice because they weren't ever hooked up to the same board. In that case we'd have a question of what to do upstream. If this really happens then I suppose (worst case) we could use the device tree to help differentiate and each board could say that "panel ID <x> hooked up to this board is actually panel <y>". I hope we don't have to do that because it feels dirty, but at least it gives us _something_ if we get backed into a corner. > 2. You are working with edp panels - beside EDID they have DPCD which > contains things like IEEE_OUI and "Device Identification String", I > guess they could be also used for detecting panels, have you considered > it? I think DPCD Id should be assigned to EDP-Sink interface, and EDID > Id to the actual panel behind it. With this assumption one could > consider which timings should be property of which entity. This could be another way to help us if we're backed into a corner in the future. Right now the driver requires that you give access to a full eDP AUX bus to use the "generic eDP" panel support even though it currently only relies on the EDID, so it would be pretty easy to utilize this info in the future. So far the ID has been reliable for me though. -Doug
