Re: [PATCH 5/6] ARM: DTS: da850-evm: Add node for tlv320aic3106 codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello.

On 07/31/2014 02:18 PM, Peter Ujfalusi wrote:

The board uses aic3106 for audio.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
---
  arch/arm/boot/dts/da850-evm.dts | 14 ++++++++++++++
  1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
index 09118c72e83f..b9ef2be0b145 100644
--- a/arch/arm/boot/dts/da850-evm.dts
+++ b/arch/arm/boot/dts/da850-evm.dts
@@ -51,6 +51,20 @@
  			tps: tps@48 {
  				reg = <0x48>;
  			};
+			tlv320aic3106: tlv320aic3106@1b {

The "reg" property is <0x18>, why the unit-address part of a name is different? Also, the ePAPR standard [1] says:

The name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model.

+				#sound-dai-cells = <0>;
+				compatible = "ti,tlv320aic3106";
+				reg = <0x18>;
+				status = "okay";
+
+				/* Regulators */
+				IOVDD-supply = <&vdcdc2_reg>;
+				/* Derived from VBAT: Baseboard 3.3V / 1.8V */
+				AVDD-supply = <&vbat>;
+				DRVDD-supply = <&vbat>;
+				DVDD-supply = <&vbat>;
+			};
+

[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux