On Wed, Aug 4, 2021 at 8:35 AM Sanil, Shruthi <shruthi.sanil@xxxxxxxxx> wrote: > > From: Rob Herring <robh@xxxxxxxxxx> > > Sent: Tuesday, August 3, 2021 4:14 AM ... > > > +properties: > > > > You need a 'compatible' here. Otherwise, how does one know what 'reg' > > contains. Also, without it, this schema will never be applied. > > > > This is a parent block that has the common configuration register address defined which we would need during the initialization of the child nodes. This block in itself is not doing anything. We have this because, we have a common register that is required to be accessed during all the timers and counter initialization. > The child nodes have the compatible string, which is used in the driver. I have validated this on the Keem Bay HW and see that the timer probes are being called and the timers are functional as expected. I think I understand now. The problem is that the current state of affairs with this block is incorrect software representation. What you need is to create an MFD device driver (for which the compatible will exactly the one Rob is telling about) and from it you register the rest of your drivers. The existing drivers for this block should be converted to MFD schema. -- With Best Regards, Andy Shevchenko
