On 29.07.2021 12:50, Thara Gopinath wrote: > Hi Konrad, > > On 7/28/21 6:25 PM, Konrad Dybcio wrote: >> This will enable temperature reporting for various SoC >> components. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/thermal/qcom-tsens.yaml | 1 + >> arch/arm64/boot/dts/qcom/sdm630.dtsi | 11 +++++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> index 4a2eaf28e3fd..d3b9e9b600a2 100644 >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> @@ -48,6 +48,7 @@ properties: >> - qcom,sc7180-tsens >> - qcom,sc7280-tsens >> - qcom,sc8180x-tsens >> + - qcom,sdm630-tsens >> - qcom,sdm845-tsens >> - qcom,sm8150-tsens >> - qcom,sm8250-tsens >> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> index 1e54828817d5..7e9c80e35fba 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi >> @@ -627,6 +627,17 @@ mnoc: interconnect@1745000 { >> <&mmcc AHB_CLK_SRC>; >> }; >> + tsens: thermal-sensor@10ae000 { >> + compatible = "qcom,sdm630-tsens", "qcom,tsens-v2"; >> + reg = <0x010ae000 0x1000>, /* TM */ >> + <0x010ad000 0x1000>; /* SROT */ >> + #qcom,sensors = <12>; > > Are all 12 sensors used ? I see that in a later patch "arm64: dts: qcom: sdm630: Add thermal-zones configuration" only 9 are used. Hi, if I recall correctly, they all give output but not all of the mappings were documented in the downstream sources and we have no documentation whatsoever :( Konrad