Hi, I was looking at MTK pinctrl stuff upstream, and it seems there are a few `mediatek,pull-*-adv` entries that have invalid values: arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-down-adv = <10>; arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: mediatek,pull-up-adv = <10>; According to the bindings, the values should 0~3. <10> is probably a incorrect attempt at using binary representation, which is wrong. This probably leads to the pull-up/down getting disabled or ignored. Cound people still working on these two devices take a look? Regards ChenYu
