> -----Original Message----- > From: Fabio Estevam <festevam@xxxxxxxxx> > Sent: 2021年7月15日 20:40 > To: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > Cc: Joakim Zhang <qiangqing.zhang@xxxxxxx>; Rob Herring > <robh+dt@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sascha Hauer > <s.hauer@xxxxxxxxxxxxxx>; Sascha Hauer <kernel@xxxxxxxxxxxxxx>; > dl-linux-imx <linux-imx@xxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; Aisheng Dong > <aisheng.dong@xxxxxxx> > Subject: Re: [PATCH] arm64: dts: imx8mp: remove fallback compatible string > for FlexCAN > > Hi Marc, > > On Thu, Jul 15, 2021 at 9:33 AM Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> > wrote: > > > > Why? > > > > Don't remember exactly why It doesn't work. I think it was a missing > > quirk that the imx6 doesn't need. > > > > > "fsl,imx8mp-flexcan" is passed as the more specific compatible > > > string and it should match against it first. > > > > ACK - but why specify the imx6 in the compatible list if the flexcan > > IP core isn't compatible with the one of the imx6? > > Correct. The change in this patch looks good. > > The commit log needs improvement though. Ok, I will improve the commit message and then resend the patch. Best Regards, Joakim Zhang
