Hi Drew, On Sat, Jul 3, 2021 at 8:46 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote: > On Fri, Jul 02, 2021 at 11:03:56PM +0200, Geert Uytterhoeven wrote: > > On Fri, Jul 2, 2021 at 10:56 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote: > > > On Thu, Jul 01, 2021 at 10:34:56AM +0200, Geert Uytterhoeven wrote: > > > > On Thu, Jul 1, 2021 at 2:22 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote: > > > > > Add bindings for the GPIO controller in the StarFive JH7100 SoC [1]. > > > > > > > > > > [1] https://github.com/starfive-tech/beaglev_doc > > > > > > > > > > Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx> > > > > > Signed-off-by: Huan Feng <huan.feng@xxxxxxxxxxxxxxxx> > > > > > > > > Thanks for your patch! > > > > > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/gpio/starfive,jh7100-gpio.yaml > > > > > @@ -0,0 +1,60 @@ > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/gpio/starfive,jh7100-gpio.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: StarFive JH7100 GPIO controller > > > > > + > > > > > +maintainers: > > > > > + - Huan Feng <huan.feng@xxxxxxxxxxxxxxxx> > > > > > + - Drew Fustini <drew@xxxxxxxxxxxxxxx> > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + items: > > > > > + - const: starfive,jh7100-gpio > > > > > + > > > > > + reg: > > > > > + maxItems: 1 > > > > > + > > > > > + interrupts: > > > > > + description: > > > > > + Interrupt mapping, one per GPIO. Maximum 32 GPIOs. > > > > > + minItems: 1 > > > > > + maxItems: 32 > > > > > > > > What about clocks and resets? > > > But I am not sure how reset would work? > > > > That should become "resets = <&rstgen JH7100_RSTN_GPIO_APB>", > > but we don't have the reset controller in Linux yet (we do in barebox). > > Do you think I should add reset item like this? > > resets: > maxItems: 1 > > I suppose this is supposed to describe the hardware and it shouldn't > matter whether or not Linux uses the property, right? Exactly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
