Hi Drew, On Thu, Jul 1, 2021 at 2:22 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote: > Add bindings for the GPIO controller in the StarFive JH7100 SoC [1]. > > [1] https://github.com/starfive-tech/beaglev_doc > > Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx> > Signed-off-by: Huan Feng <huan.feng@xxxxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/starfive,jh7100-gpio.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/gpio/starfive,jh7100-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive JH7100 GPIO controller > + > +maintainers: > + - Huan Feng <huan.feng@xxxxxxxxxxxxxxxx> > + - Drew Fustini <drew@xxxxxxxxxxxxxxx> > + > +properties: > + compatible: > + items: > + - const: starfive,jh7100-gpio > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: > + Interrupt mapping, one per GPIO. Maximum 32 GPIOs. > + minItems: 1 > + maxItems: 32 What about clocks and resets? > + > + gpio-controller: true > + > + "#gpio-cells": > + const: 2 > + > + interrupt-controller: true > + > + "#interrupt-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + - "#interrupt-cells" > + - "#gpio-cells" > + - gpio-controller > + > +additionalProperties: false > + > +examples: > + - | > + gpio@11910000 { > + compatible = "starfive,jh7100-gpio"; > + reg = <0x11910000 0x10000>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <32>; > + }; > + > +... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
