Hi Benoit,
>
> > + };
> > +
> > + serial@12000 {
> > + clocks = <&coreclk 0>;
I don't think you need the clocks property. It should be already set
in armada-xp.dtsi.
> > + adt7473@2e {
> > + compatible = "adt7473";
Please include a vendor prefix here.
> > + reg = <0x2e>;
> > + };
> > +
> > + pcf8563@51 {
> > + compatible = "pcf8563";
and a vendor prefix here.
> > + /* warning: you need both eth1 & 0 to be initialize for poweroff to shutdown otherwise it reboots */
What do you mean by initialized? Driver loaded? Interface up?
> This is a great first version
I agree with Jason, well done.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
