Hi Geert, Thank you for the patch. On Thu, Jun 10, 2021 at 11:37:17AM +0200, Geert Uytterhoeven wrote: > Add support for the R-Car H3e-2G (R8A779M1) and M3e-2G (R8A779M3) SoCs. > These are different gradings of the R-Car H3 ES3.0 (R8A77951) and M3-W+ > (R8A77961) SoCs, and thus subject to the same quirks. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > drivers/mmc/host/renesas_sdhi_core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c > index b719eda6b8619453..0478c9d58b965392 100644 > --- a/drivers/mmc/host/renesas_sdhi_core.c > +++ b/drivers/mmc/host/renesas_sdhi_core.c > @@ -943,6 +943,8 @@ static const struct soc_device_attribute sdhi_quirks_match[] = { > { .soc_id = "r8a77965", .data = &sdhi_quirks_r8a77965 }, > { .soc_id = "r8a77980", .data = &sdhi_quirks_nohs400 }, > { .soc_id = "r8a77990", .data = &sdhi_quirks_r8a77990 }, > + { .soc_id = "r8a779m1", .data = &sdhi_quirks_bad_taps2367 }, > + { .soc_id = "r8a779m3", .data = &sdhi_quirks_bad_taps1357 }, Could we reuse the entries for H3 and M3 instead, by dropping the "ES3.*" revision ? > { /* Sentinel. */ }, > }; > -- Regards, Laurent Pinchart