On Tuesday 22 July 2014 13:42:00 Sylwester Nawrocki wrote: > On 14/07/14 11:56, Mark Rutland wrote: > >> diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > >> > index 937b755..3142745 100644 > >> > --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > >> > +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > >> > @@ -3,9 +3,12 @@ Samsung S5P/EXYNOS SoC series JPEG codec > >> > Required properties: > >> > > >> > - compatible : should be one of: > >> > - "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg"; > >> > + "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg", > >> > + "samsung,exynos3250-jpeg"; > >> > - reg : address and length of the JPEG codec IP register set; > >> > - interrupts : specifies the JPEG codec IP interrupt; > >> > -- clocks : should contain the JPEG codec IP gate clock specifier, from the > >> > +- clocks : should contain the JPEG codec IP gate clock specifier and > >> > + for the Exynos3250 SoC additionally the SCLK_JPEG entry; from the > >> > common clock bindings; > >> > -- clock-names : should contain "jpeg" entry. > >> > +- clock-names : should contain "jpeg" entry and additionally "sclk-jpeg" entry > >> > + for Exynos3250 SoC > > > > Please turn this into a list for easier reading, e.g. > > > > - clock-names: should contain: > > * "jpeg" for the gate clock. > > * "sclk-jpeg" for the SCLK_JPEG clock (only for Exynos3250). > > > > You could also define clocks in terms of clock-names to avoid > > redundancy. > > > > The SCLK_JPEG name sounds like a global name for the clock. Is there a > > name for the input line on the JPEG block this is plugged into? > > There is unfortunately no such name for SCLK_JPEG clock in the IP's block > documentation. For most of the multimedia IPs clocks are documented > only in the clock controller chapter, hence the names may appear global. > Probably "gate", "sclk" would be good names, rather than "<IP_NAME>", > "<IP_NAME>-sclk". But people kept using the latter convention and now > it's spread all over and it's hard to change it. > Since now we can't rename "jpeg" and other IPs I'd assume it's best > to stay with "jpeg", "sclk-jpeg". We just had the exact same discussion about the addition of the sclk for the adc in exynos3250 and ended up calling it just "sclk" instead of "sclk-adc" there. I think it would be best to do the same here and use "sclk" instead of "sclk-jpeg". Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
