On Fri, Jul 11, 2014 at 04:19:49PM +0100, Jacek Anaszewski wrote: > JPEG IP on Exynos3250 SoC requires enabling two clock > gates for its operation. This patch documents this > requirement. > > Signed-off-by: Jacek Anaszewski <j.anaszewski@xxxxxxxxxxx> > Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Pawel Moll <pawel.moll@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> > Cc: Kumar Gala <galak@xxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > --- > .../bindings/media/exynos-jpeg-codec.txt | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > index 937b755..3142745 100644 > --- a/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > +++ b/Documentation/devicetree/bindings/media/exynos-jpeg-codec.txt > @@ -3,9 +3,12 @@ Samsung S5P/EXYNOS SoC series JPEG codec > Required properties: > > - compatible : should be one of: > - "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg"; > + "samsung,s5pv210-jpeg", "samsung,exynos4210-jpeg", > + "samsung,exynos3250-jpeg"; > - reg : address and length of the JPEG codec IP register set; > - interrupts : specifies the JPEG codec IP interrupt; > -- clocks : should contain the JPEG codec IP gate clock specifier, from the > +- clocks : should contain the JPEG codec IP gate clock specifier and > + for the Exynos3250 SoC additionally the SCLK_JPEG entry; from the > common clock bindings; > -- clock-names : should contain "jpeg" entry. > +- clock-names : should contain "jpeg" entry and additionally "sclk-jpeg" entry > + for Exynos3250 SoC Please turn this into a list for easier reading, e.g. - clock-names: should contain: * "jpeg" for the gate clock. * "sclk-jpeg" for the SCLK_JPEG clock (only for Exynos3250). You could also define clocks in terms of clock-names to avoid redundancy. The SCLK_JPEG name sounds like a global name for the clock. Is there a name for the input line on the JPEG block this is plugged into? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
