On Sat 12 Jun 15:54 CDT 2021, Caleb Connolly wrote: > Add bindings for Qualcomm QPNP haptics, setting default values used on > most devices. > > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index d230c510d4b7..ccf64c1898d4 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -1,4 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > +#include <dt-bindings/input/qcom,qpnp-haptics.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/spmi/spmi.h> > > @@ -41,5 +42,20 @@ lab: lab { > interrupt-names = "sc-err", "ocp"; > }; > }; > + > + qpnp_haptics: qcom,haptics@c000 { No qcom, in node name, please. > + compatible = "qcom,qpnp-haptics"; > + reg = <0xc000 0x100>; #size-cells is <0>, so this means 2 addresses. Please drop the "length". Regards, Bjorn > + > + interrupts = <0x3 0xc0 0x0 IRQ_TYPE_EDGE_BOTH>, > + <0x3 0xc0 0x1 IRQ_TYPE_EDGE_BOTH>; > + interrupt-names = "short", "play"; > + > + qcom,wave-shape = <HAP_WAVE_SINE>; > + qcom,play-mode = <HAP_PLAY_BUFFER>; > + qcom,brake-pattern = <0x3 0x3 0x2 0x1>; > + > + status = "disabled"; > + }; > }; > }; > -- > 2.31.1 > >