Hi Daniel, On Wed, May 19, 2021 at 10:23 PM Daniel Mack <daniel@xxxxxxxxxx> wrote: > This new optional property can be used to control the function of the > auxiliary output pin. Introduce a new dt-bindings include file that > contains the numerical values. > > Signed-off-by: Daniel Mack <daniel@xxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml > +++ b/Documentation/devicetree/bindings/clock/cirrus,cs2000-cp.yaml > @@ -37,6 +37,16 @@ properties: > reg: > maxItems: 1 > > + cirrus,aux-output-source: > + description: > + Specfies the function of the auxililary clock output pin Specifies ... auxiliary > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: > + - 0 # CS2000CP_AUX_OUTPUT_REF_CLK: ref_clk input > + - 1 # CS2000CP_AUX_OUTPUT_CLK_IN: clk_in input > + - 2 # CS2000CP_AUX_OUTPUT_CLK_OUT: clk_out output > + - 3 # CS2000CP_AUX_OUTPUT_PLL_LOCK: pll lock status Should the default be documented? "default: 0"? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds