Hi, On Fri, Jul 18, 2014 at 09:27:28PM +0400, Sergei Shtylyov wrote: > On 07/18/2014 04:30 PM, Antoine Ténart wrote: > > >diff --git a/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > >new file mode 100644 > >index 000000000000..88f8c23384c0 > >--- /dev/null > >+++ b/Documentation/devicetree/bindings/phy/berlin-sata-phy.txt > >@@ -0,0 +1,34 @@ > >+Berlin SATA PHY > >+--------------- > >+ > >+Required properties: > >+- compatible: should be "marvell,berlin2q-sata-phy" > >+- address-cells: should be 1 > >+- size-cells: should be 0 > >+- phy-cells: from the generic PHY bindings, must be 1 > > It's "#address-cells", "#size-cells", and "#phy-cells". Sure. > > >+- reg: address and length of the register > >+- clocks: reference to the clock entry > >+ > >+Sub-nodes: > >+Each PHY should be represented as a sub-node. > > Then "#phy-cells" should also belong to the sub-nodes. No, because the PHY provider is still the parent. Antoine -- Antoine Ténart, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
