On 03.06.21 16:49, Grzegorz Szymaszek wrote: > Hello Ahmad, > > On Thu, Jun 03, 2021 at 04:26:59PM +0200, Ahmad Fatoum wrote: >> On 03.06.21 16:23, Grzegorz Szymaszek wrote: >>> The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. >>> stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI >>> interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is >>> incompatible with the pins used on the Odyssey board, where: >>> - there are 8 data pins instead of 12, >>> - […] >>> >>> Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in >>> the Odyssey device tree. >> >> Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that >> instead of overriding an existing one. > > Can I simply use dcmi_pins_b (as the first unused identifier) or is > there some way to match specific pin groups to an identifier (b, c, d, > and so on)? Just take the next available. That's how I did it so far. >> Current convention is also to place all STM32MP1 pinctrl nodes into >> a central file, not in the individual board device trees. > > Sure, I will update the patch. > > Thanks for your comments! Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
