On Wed, Jun 2, 2021 at 6:47 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote: > > On Wed, 2 Jun 2021 at 13:24, Anup Patel <anup.patel@xxxxxxx> wrote: > > > > The generic power domain related code in PSCI domain driver is largely > > independent of PSCI and can be shared with RISC-V SBI domain driver > > hence we factor-out this code into dt_idle_genpd.c and dt_idle_genpd.h. > > > > Signed-off-by: Anup Patel <anup.patel@xxxxxxx> > > Reviewed-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > > A small nitpick below. > > [...] > > > +EXPORT_SYMBOL_GPL(dt_idle_pd_free); > > Do we really need to export this symbol? Looks like there are only > built-in cpuidle drivers that are going to use it. At least for now. > > As a matter of fact, the same comment applies to all cases of > EXPORT_SYMBOL_GPL from $subject patch. Can we drop all of them? I had kept the EXPORT_SYMBOL_GPL() to be in-sync with the dt_idle_states.c but in this case I agree we don't need to export. I will drop all EXPORT_SYMBOL_GPL() in the next patch revision. Regards, Anup > > [...] > > Kind regards > Uffe
