On Wed, Jun 2, 2021 at 12:47 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > On Mon, 31 May 2021, Robert Marko wrote: > > > Add binding documents for the Delta TN48M CPLD drivers. > > > > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx> > > --- > > Changes in v3: > > * Include bindings for reset driver > > > > Changes in v2: > > * Implement MFD as a simple I2C MFD > > * Add GPIO bindings as separate > > > > .../bindings/gpio/delta,tn48m-gpio.yaml | 42 +++++++++ > > .../bindings/mfd/delta,tn48m-cpld.yaml | 90 +++++++++++++++++++ > > .../bindings/reset/delta,tn48m-reset.yaml | 35 ++++++++ > > 3 files changed, 167 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml > > create mode 100644 Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml > > create mode 100644 Documentation/devicetree/bindings/reset/delta,tn48m-reset.yaml > > > +++ b/Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/delta,tn48m-cpld.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Delta Networks TN48M CPLD controller > > + > > +maintainers: > > + - Robert Marko <robert.marko@xxxxxxxxxx> > > + > > +description: | > > + Lattice CPLD onboard the TN48M switches is used for system > > + management. > > + > > + It provides information about the hardware model, revision, > > + PSU status etc. > > + > > + It is also being used as a GPIO expander for the SFP slots and > > + reset controller for the switch MAC-s and other peripherals. > > + > > +properties: > > + compatible: > > + const: delta,tn48m-cpld > > + > > + reg: > > + description: > > + I2C device address. > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > +required: > > + - compatible > > + - reg > > + - "#address-cells" > > + - "#size-cells" > > + > > +patternProperties: > > + "^gpio(@[0-9a-f]+)?$": > > + $ref: ../gpio/delta,tn48m-gpio.yaml > > + > > + "^reset-controller?$": > > + $ref: ../reset/delta,tn48m-reset.yaml > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + cpld@41 { > > + compatible = "delta,tn48m-cpld"; > > + reg = <0x41>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + gpio@31 { > > + compatible = "delta,tn48m-gpio-sfp-tx-disable"; > > + reg = <0x31>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + }; > > + > > + gpio@3a { > > + compatible = "delta,tn48m-gpio-sfp-present"; > > + reg = <0x3a>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + }; > > + > > + gpio@40 { > > + compatible = "delta,tn48m-gpio-sfp-los"; > > + reg = <0x40>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + }; > > + > > + reset-controller { > > + compatible = "delta,tn48m-reset"; > > + #reset-cells = <1>; > > + }; > > How is the Reset component addressed? It has a defined register in the driver. Now that I think of it, it would make sense to use reg for it like for the GPIO and not hardcode it. Regards, Robert > > > + }; > > + }; > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@xxxxxxxxxx Web: www.sartura.hr
